Signing #331
Merged
Signing #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iulianpascalau
changed the base branch from
feat/migration-app
to
create-migration-app
sstanculeanu
reviewed
Sep 4, 2024
clients/errors.go
Outdated
| @@ -35,4 +35,7 @@ var ( | |||
|
|
|||
| // ErrNoPendingBatchAvailable signals that no pending batch is available | |||
| ErrNoPendingBatchAvailable = errors.New("no pending batch available") | |||
|
|
|||
| // ErrNilCryptoHandler signals that a nil crypto handler key was provided | |||
There was a problem hiding this comment.
Suggested change
| // ErrNilCryptoHandler signals that a nil crypto handler key was provided | |
| // ErrNilCryptoHandler signals that a nil crypto handler was provided |
clients/ethereum/client_test.go
Outdated
| } | ||
| args.CryptoHandler = &bridgeTests.CryptoHandlerStub{ | ||
| SignCalled: func(msgHash common.Hash) ([]byte, error) { | ||
| assert.Equal(t, msgHash.Bytes(), hash.Bytes()) |
There was a problem hiding this comment.
Suggested change
| assert.Equal(t, msgHash.Bytes(), hash.Bytes()) | |
| assert.Equal(t, hash.Bytes(), msgHash.Bytes()) |
clients/ethereum/client_test.go
Outdated
| } | ||
| args.CryptoHandler = &bridgeTests.CryptoHandlerStub{ | ||
| SignCalled: func(msgHash common.Hash) ([]byte, error) { | ||
| assert.Equal(t, msgHash.Bytes(), hash.Bytes()) |
There was a problem hiding this comment.
Suggested change
| assert.Equal(t, msgHash.Bytes(), hash.Bytes()) | |
| assert.Equal(t, hash.Bytes(), msgHash.Bytes()) |
dragos-rebegea
previously approved these changes
Sep 4, 2024
iulianpascalau
dismissed
dragos-rebegea’s stale review
The base branch was changed.
- added unique identifiers for output files
dragos-rebegea
approved these changes
Sep 5, 2024
dragos-rebegea
previously approved these changes
Sep 5, 2024
dragos-rebegea
approved these changes
Sep 5, 2024
sstanculeanu
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.